Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for awsvpc on ecs_taskdefinition module and ecs_service #34369

Closed
wants to merge 1 commit into from
Closed

Add support for awsvpc on ecs_taskdefinition module and ecs_service #34369

wants to merge 1 commit into from
+8 −5

Conversation

jorgegviana
Copy link

SUMMARY

Add support for awsvpc on ecs_taskdefinition module and network_configuration parameter to ecs_service (required for awsvpc).

Add option 'awsvpc' for network_configuration parameter in ecs_taskdefinition module
Add parameter network_configuration in ecs_service (required to create a service using awsvpn network mode)

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ecs_taskdefinition
ecs_service

ANSIBLE VERSION
ansible 2.4.2.0
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/Users/jviana/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.12 (default, Jun 29 2016, 14:05:02) [GCC 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)]
ADDITIONAL INFORMATION

@jorgegviana
Add support for awsvpc on ecs_taskdefinition module and network_confi…
fcf275e 
…guration parameter to ecs_service (required for awsvpc).
@ansibot
Copy link
Contributor

ansibot commented Jan 2, 2018

cc @Java1Guy @Java1Guy @kaczynskid @simplesteph @willthames @zacblazic
click here for bot help

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws cloud community_review In order to be merged, this PR must follow the community review workflow. feature_pull_request module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jan 2, 2018
@willthames
Copy link
Contributor

I've been working on this too - I've just created a WIP PR at #34831 to compare approaches

The main points of comparison are

  • Updated documentation
  • Updated tests
  • Checks whether botocore can cope with networkConfiguration before passing it through as a parameter
  • network_configuration parameter is in Ansible format, and can cope with named security groups as well as security group IDs

If you can apply a similar approach to ecs_service, then the two PRs combined should get us pretty close.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jan 3, 2018
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jan 11, 2018
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jan 27, 2018
@ansibot ansibot added feature This issue/PR relates to a feature request. and removed feature_pull_request labels Mar 2, 2018
@ansibot
Copy link
Contributor

ansibot commented Jan 31, 2020

cc @jillr @s-hertel @tremble
click here for bot help

@ansibot ansibot added collection Related to Ansible Collections work collection:community.aws needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md labels Apr 29, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 16, 2020

Thank you very much for your interest in Ansible. Ansible has migrated much of the content into separate repositories to allow for more rapid, independent development. We are closing this issue/PR because this content has been moved to one or more collection repositories.

For further information, please see:
https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md

@ansibot ansibot closed this Aug 16, 2020
@ansible ansible locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws bot_closed cloud collection:community.aws collection Related to Ansible Collections work feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_collection_redirect https://github.com/ansible/ansibullbot/blob/master/docs/collection_migration.md needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorgegviana @ansibot @willthames